fix: drop unsupported subsystem_levels kwarg from build_problem calls#1
Open
aarontrowbridge wants to merge 1 commit intomainfrom
Open
fix: drop unsupported subsystem_levels kwarg from build_problem calls#1aarontrowbridge wants to merge 1 commit intomainfrom
aarontrowbridge wants to merge 1 commit intomainfrom
Conversation
Piccolo's `SplinePulseProblem` does not accept a `subsystem_levels` kwarg; the required information is already carried by the `EmbeddedOperator` goal that lives on the trajectory. Stretto was passing this kwarg in two places (`compile_block` and `_compile_block_with_strategy`), causing `SplinePulseProblem` to throw `MethodError: ... got unsupported keyword argument "subsystem_levels"` once the upstream composite-system path was correctly exercised end-to-end. Validated against the Strettissimo v0.1 integration suite (2Q H→CZ + 3Q Toffoli full compile_block runs) — 8/8 PASS, 5m46s. Depends on Piccolo PR #144 (AbstractQuantumSystem parity for CompositeQuantumSystem) for the full pipeline to run to Ipopt; this Stretto-side change is independent and non-breaking on its own. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Piccolo's
SplinePulseProblemdoes not accept asubsystem_levelskwarg — the info is already carried by theEmbeddedOperatorgoal attached to the trajectory. Stretto was passing this kwarg in two call sites (compile_blockand_compile_block_with_strategy), so any end-to-end run through the Piccolo API threw:This was masked from CI because
compile_blockintegration tests were sentinel-instrumented at commit a3a8e6e to never reach the solve. The failure surfaced once the Strettissimo v0.1 suite exercised the full pipeline end-to-end on a patched Piccolo.Changes
src/compile.jl— dropsubsystem_levels = sys.subsystem_levelsfrom bothbuild_problem(...)call sites.Test plan
Dependencies
🤖 Generated with Claude Code