Test that logged simple handler errors has a stack#4519
Merged
Marsup merged 1 commit intohapijs:masterfrom Oct 24, 2024
Merged
Conversation
Marsup
force-pushed
the
error-log-stack
branch
from
0d6bcb0 to
dbbee2c
Compare
Contributor
|
Looks like it passes now that hoek 11.0.5 is released. I'll make another PR to force that version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a test for the
error.stackproperty to illustrate a node v22 regression.This should be able to be fixed with hapijs/hoek#390.
Again, feel free to backport my old PR to fix this, but personally I would prefer to declare that Hapi v21 and any modules that use
Hoek.clone()on potential errors (at least Hoek, Boom, and Podium) does not support node 21+.