Skip to content

Made casts explicit in the IRPrinter and StmtToHtml #9057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mcourteaux wants to merge 5 commits into
base: main
Choose a base branch
from
+50 −26
Open

Made casts explicit in the IRPrinter and StmtToHtml #9057

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1c03712
Made casts explicit in the IRPrinter and StmtToHtml
mcourteaux Mar 17, 2026
34e01b6
IRPrinter: Let and LetStmt have explicit type: let varname : type = v…
mcourteaux Mar 17, 2026
14a649a
Fixup for correctness/callable_errors
mcourteaux Mar 17, 2026
db31812
Reflect changes in StmtToHtml.
mcourteaux Mar 17, 2026
79a83ba
Fixup test_internal for IRPrinter.
mcourteaux Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/IRPrinter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -796,7 +796,7 @@ void IRPrinter::visit(const StringImm *op) {
}

void IRPrinter::visit(const Cast *op) {
stream << type(op->type);
stream << kw("cast<") << type(op->type) << kw(">");
openf();
print_no_parens(op->value);
closef();
Expand Down
10 changes: 6 additions & 4 deletions src/StmtToHTML.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1429,19 +1429,21 @@ class HTMLCodePrinter : public IRVisitor {
void visit(const Cast *op) override {
std::string type_str = type_to_string(op->type);
print_opening_tag("span", "Cast");
print_opening_tag("span", "matched");
print_opening_tag("span", "matched keyword");
print_text("cast&lt;");
print_type(op->type);
print_text("(");
print_text("&gt;");
print_closing_tag("span");
print_html_element("span", "matched", "(", type_str);
print(op->value);
print_html_element("span", "matched", ")");
print_html_element("span", "matched", ")", type_str);
print_closing_tag("span");
}

void visit(const Reinterpret *op) override {
std::string type_str = type_to_string(op->type);
print_opening_tag("span", "Reinterpret");
print_opening_tag("span", "matched Symbol", type_str);
print_opening_tag("span", "matched keyword", type_str);
print_text("reinterpret&lt;");
print_type(op->type);
print_text("&gt;");
Expand Down
Loading