Change entry point of IRMutator and IRVisitor to operator().#9023
Open
mcourteaux wants to merge 8 commits intohalide:mainfrom
Open
Change entry point of IRMutator and IRVisitor to operator().#9023mcourteaux wants to merge 8 commits intohalide:mainfrom
mcourteaux wants to merge 8 commits intohalide:mainfrom
Conversation
alexreinking
approved these changes
Mar 16, 2026
Contributor
Author
|
Will wait for @vksnk to judge whether Google can handle this change. |
mcourteaux
added
the
release_notes
abadams
reviewed
Mar 23, 2026
Member
|
I don't think we should make the logging changes in Lower.cpp in the same PR as changing the mutator entrypoint. We should discuss that separately. |
Member
I made this change. |
alexreinking
approved these changes
Mar 24, 2026
Member
|
Glad I remembered to enable the buildbots here! Only they test the apps at the moment... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only place in production code where changes might be required is in custom lowering passes calling custom mutators/visitors. See for example: correctness/specialize.cpp