Allow to configure retry policy on a per-task basis#790
Open
nishiol wants to merge 3 commits intogruelbox:masterfrom
Open
Allow to configure retry policy on a per-task basis#790nishiol wants to merge 3 commits intogruelbox:masterfrom
nishiol wants to merge 3 commits intogruelbox:masterfrom
Conversation
|
The ideea looks interesting. The upside is that DB changes are not needed, and there is flexibility in applying different strategies. The downside is that you need to implement a specific interface. I didn’t review in detail at the code, but from what I can tell, the idea should work |
Author
|
Yes, it's kind of tight coupling. But if this a problem, it could be avoided by creating an implementing class in the module which depends on transaction-outbox stuff. It'll look like some wrapper around your business logic class which you want to be called by transaction-outbox. |
Member
|
Hey, sorry about the delay here. I've proposed a solution to cover all use cases here: #737 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on discussion: #737
Similar PR: #739
Allows to configure retry policy on per-task basis in programmatic way. No db migrations needed.
Usage example can be found in README.md
@lburja could you please also take a look at this PR?