Allow TransactionOutboxImpl#scheduler and ExecutorSubmitter#executor programmatic shutdown

[reda-alaoui]

Fix #686

Makes TransactionOutbox and Submitter implement AutoCloseable.

Please note that if any instance is declared as a Spring bean, Spring will automatically call the close method on shutdown, which is very convenient.

[badgerwithagun]

@reda-alaoui I don't understand why the change to ExecutorSubmitter.

Currently it doesn't control the lifetime of the supplied Executor; your application does. You can easily shut your executor down without needing TransactionOutboxImpl to do it - in fact it seems quite strange to me to expect it to do so. Maybe I'm missing something?

I think the right answer for the scheduler in TransactionOutboxImpl is to go for the same approach: make it a builder option when creating the TransactionOutbox, which defaults to the same behaviour as currently.

[reda-alaoui]

@badgerwithagun,

Do you consider like me that the Submitter should be AutoCloseable ? Considering that the answer is yes, I apply the following rule: any AutoCloseable instance B created by another AutoCloseable instance A should be closed by instance A when instance A is closed. IMO, without this, apis involving AutoCloseable are not consistent and are error prone.

[badgerwithagun]

I don't see why the Executorubmitter should be autocloseable, no - it doesn't manage any resource lifetimes.

Any Executor it works with is created outside and thus should have its lifetime managed outside.

A good rule of thumb is that whatever creates a resource should close it. ExecutorSubmitter doesn't create any resources.

[reda-alaoui]

@badgerwithagun ExecutorSubmitter does not create an executor, but Submitter does here. AutoCloseable was originally added to Submitter because of this.

[badgerwithagun]

But you don't need to use this method.

You can just create a TransactionOutbox with your own.

var outbox = TransactionOutbox.builder()
   .submitter(ExecutorSubmitter.builder().executor(yourExecutor).build())
   ...
   .builder();

This is almost always what you do in a managed environment. The default Submitter implementation uses ForkJoinPool, which is a very bad idea when running in an application container.

[badgerwithagun]

.