Closed
Conversation
zhiyanfoo
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8838 +/- ##
=======================================
Coverage 83.29% 83.29%
=======================================
Files 414 414
Lines 32753 32777 +24
=======================================
+ Hits 27280 27301 +21
Misses 4070 4070
- Partials 1403 1406 +3
🚀 New features to boost your workflow:
|
grpc issue: grpc/grpc#38062 I spent a while trying to figure out whether or not ServerName should take precedence over HostRewriteHeader. It seems that in the simplest config of a dns resolver, ServerName is being set, even though there are docs that say it should usually be empty. Similarly when targeting an xDS target, ServerName is also set. So in order for this to work HostRewriteHeader must take precedence over ServerName. Credit to Rob for the initial version of this.
atollena
added
Type: Feature
Collaborator
|
Closing for now, as grpc/proposal#533 needs to be approved first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements respecting the
host_rewriteroute action for grpc-xds clients. The grpc-proposal for this issue is here.There was also an initial discussion here
RELEASE NOTES:
host_rewriteroute action for grpc-xds clients. gRFC A111