Skip to content

missing fixes for comments from easwar

8816ae5
Select commit
Loading
Failed to load commit list.
Merged

ringhash: implement gRFC A76 #8159

missing fixes for comments from easwar
8816ae5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 7, 2025 in 0s

81.97% (+0.06%) compared to a51009d

View this Pull Request on Codecov

81.97% (+0.06%) compared to a51009d

Details

Codecov Report

Attention: Patch coverage is 97.45223% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.97%. Comparing base (a51009d) to head (8816ae5).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
internal/testutils/xds/e2e/clientresources.go 75.00% 1 Missing and 1 partial ⚠️
xds/internal/balancer/ringhash/picker.go 96.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8159      +/-   ##
==========================================
+ Coverage   81.91%   81.97%   +0.06%     
==========================================
  Files         410      412       +2     
  Lines       40216    40498     +282     
==========================================
+ Hits        32942    33198     +256     
- Misses       5894     5912      +18     
- Partials     1380     1388       +8     
Files with missing lines Coverage Δ
internal/envconfig/envconfig.go 100.00% <ø> (ø)
internal/metadata/metadata.go 82.08% <100.00%> (+1.44%) ⬆️
internal/testutils/envconfig.go 100.00% <100.00%> (ø)
resolver/ringhash/attr.go 100.00% <100.00%> (ø)
...internal/balancer/clusterresolver/configbuilder.go 91.22% <100.00%> (+0.05%) ⬆️
xds/internal/balancer/ringhash/config.go 92.10% <100.00%> (+3.21%) ⬆️
xds/internal/balancer/ringhash/ring.go 100.00% <100.00%> (ø)
xds/internal/balancer/ringhash/ringhash.go 94.22% <100.00%> (+0.35%) ⬆️
xds/internal/balancer/ringhash/util.go 100.00% <100.00%> (ø)
xds/internal/resolver/serviceconfig.go 85.71% <100.00%> (ø)
... and 3 more

... and 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.