Skip to content

ringhash: implement gRFC A76

5f56c4c
Select commit
Loading
Failed to load commit list.
Merged

ringhash: implement gRFC A76 #8159

ringhash: implement gRFC A76
5f56c4c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 19, 2025 in 0s

82.44% (+0.01%) compared to a0a739f

View this Pull Request on Codecov

82.44% (+0.01%) compared to a0a739f

Details

Codecov Report

Attention: Patch coverage is 97.35099% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.44%. Comparing base (a0a739f) to head (5f56c4c).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
internal/testutils/xds/e2e/clientresources.go 75.00% 1 Missing and 1 partial ⚠️
xds/internal/balancer/ringhash/picker.go 96.29% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8159      +/-   ##
==========================================
+ Coverage   82.42%   82.44%   +0.01%     
==========================================
  Files         392      393       +1     
  Lines       39106    39212     +106     
==========================================
+ Hits        32232    32327      +95     
- Misses       5564     5571       +7     
- Partials     1310     1314       +4     
Files with missing lines Coverage Δ
internal/envconfig/envconfig.go 100.00% <ø> (ø)
internal/metadata/metadata.go 82.08% <100.00%> (+1.44%) ⬆️
resolver/ringhash/attr.go 100.00% <100.00%> (ø)
...internal/balancer/clusterresolver/configbuilder.go 91.12% <100.00%> (+0.05%) ⬆️
xds/internal/balancer/ringhash/config.go 92.10% <100.00%> (+3.21%) ⬆️
xds/internal/balancer/ringhash/ring.go 100.00% <100.00%> (+7.04%) ⬆️
xds/internal/balancer/ringhash/ringhash.go 94.37% <100.00%> (+0.44%) ⬆️
xds/internal/balancer/ringhash/util.go 100.00% <100.00%> (ø)
xds/internal/resolver/serviceconfig.go 85.71% <100.00%> (ø)
...ds/internal/xdsclient/xdsresource/unmarshal_eds.go 95.13% <100.00%> (+0.56%) ⬆️
... and 2 more

... and 20 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.