Remove unused attrs parameter from CreateChronicle and AcquireStory#641
Draft
Remove unused attrs parameter from CreateChronicle and AcquireStory#641
Conversation
…and AcquireStory The attribute map argument was advertised by the public client API but never honored — ChronicleMetaDirectory only logged it and dropped it on the floor, no Keeper/Grapher/Store code consumed any value. Removing the parameter end-to-end (public client header, facade, impl, RPC, Visor portal, metadata directory, Chronicle::addStory) makes the API stop pretending to be configurable. Also removes the orphan tiering_policy field from ChronicleAttrs and StoryAttrs (always set to *_normal in the constructor, never read), the matching enums, and the "TieringPolicy=Hot" / "Priority=High" / etc. attribute-map setup in CLI, perf bench, examples, and integration tests. Closes #575.
iameneko
added
Maintenance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The attribute map argument was advertised on both APIs but never honored — ChronicleMetaDirectory only LOG_DEBUG'd it and dropped it on the floor, and no Keeper/Grapher/Store code consumed any value. Removing the parameter end-to-end (public client header, facade, impl, RPC, Visor portal, metadata directory, Chronicle::addStory) makes the API stop pretending to be configurable. Worth rejecting over reject-with-error because we're already breaking the C++ ABI in the other umbrella PRs in this wave.
Also drops the orphan tiering_policy field and StoryTieringPolicy / ChronicleTieringPolicy enums (always set to *_normal in the constructor, never read by anything), and cleans up the TieringPolicy / Priority / IndexGranularity attribute-map setup in the CLI, perf bench, examples, integration tests, chronokvs adapter, chronoviz backend and the Python writer/reader examples.
Closes #575. Part of #572.