Drop unused flags parameter from CreateChronicle and AcquireStory#640
Draft
Drop unused flags parameter from CreateChronicle and AcquireStory#640
Conversation
…d AcquireStory The int& flags argument has been threaded through the public client API, the Visor portal, the Thallium RPC, and the metadata directory for years without ever being read or written — only logged. Removing it everywhere shrinks the API to what the system actually does and unblocks Python binding work that had to mirror the noise. Also removes Chronicle::removeArchive which has no callers anywhere in the codebase. Closes #577.
iameneko
added
Maintenance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The int& flags argument has been threaded through the public client API, the Visor portal, the Thallium RPC, and the metadata directory for years without ever being read or written — only logged. Dropping it everywhere shrinks the API to what the system actually does, and the inconsistency was one of the reasons the Python binding for these calls felt awkward.
While in the area, also deletes Chronicle::removeArchive — declared with its own dead int flags param and called from nowhere in the codebase.
Closes #577. Part of #572.