feat: implement on-chain collect for DIPs agreements#1185
Open
Maikol wants to merge 4 commits intofeat/dips-continuous-collectionfrom
Open
feat: implement on-chain collect for DIPs agreements#1185Maikol wants to merge 4 commits intofeat/dips-continuous-collectionfrom
Maikol wants to merge 4 commits intofeat/dips-continuous-collectionfrom
Conversation
The contract's abi.decode(data, (CollectIndexingFeeDataV1)) expects tuple encoding, not flat parameter encoding. Also use MaxUint256 for maxSlippage to avoid RecurringCollectorExcessiveSlippage reverts from rate limiting (tracked as TODO to investigate and switch back to 0).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.