Skip to content

chore: Linting update for new golangci#16572

Merged
paul1r merged 1 commit intomainfrom
paul1r/linting_updates
Mar 5, 2025
Merged

chore: Linting update for new golangci#16572
paul1r merged 1 commit intomainfrom
paul1r/linting_updates

Conversation

@paul1r
Copy link
Copy Markdown
Collaborator

@paul1r paul1r commented Mar 5, 2025

What this PR does / why we need it:
The Go 1.24 update updated the linting version. However, our CI checks are such that only changed files are linted. Since the Go update didn't touch any Go files, all linting issues as found by the new linter were not discovered.

This PR addresses those linting issues.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@paul1r paul1r requested a review from a team as a code owner March 5, 2025 17:40
@paul1r paul1r merged commit 27431b7 into main Mar 5, 2025
60 checks passed
@paul1r paul1r deleted the paul1r/linting_updates branch March 5, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants