ci: deflake downloads using curl#5468
Merged
coryan merged 1 commit intogoogleapis:mainfrom Apr 18, 2026
Merged
Conversation
Downloads via `curl` can and do fail due to transient errors. With this change we instruct `curl` to retry failures at least 5 times. This has no effect on successful downloads. It avoids temporary errors by trying again. It does slow down failures when the error is not temporary, but that seems like the lesser evil.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances the reliability of network requests by adding retry parameters (--retry 5 --retry-delay 15) to curl commands in GitHub Actions, Dockerfiles, and infrastructure test scripts. These changes help mitigate transient network issues during dependency installation and API calls. I have no feedback to provide.
julieqiu
approved these changes
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downloads via
curlcan and do fail due to transient errors. With this change we instructcurlto retry failures at least 5 times. This has no effect on successful downloads. It avoids temporary errors by trying again. It does slow down failures when the error is not temporary, but that seems like the lesser evil.Fixes #5458