-
Notifications
You must be signed in to change notification settings - Fork 45
feat(internal/librarian/golang): support configurable tool dependencies in librarian.yaml #5421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 14 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
b590a66
feat(golang): support configurable tool dependencies in librarian.yaml
sofisl 934656e
fix(librarian): handle nil config safely in install command
sofisl 3bd2d30
fix(golang): default to latest version for tools without specified ve…
sofisl 95cd79c
refactor(config): remove unused Exec field from GoTool and omit redun…
sofisl 979ff00
feat(golang): integrate Exec parameter usage in format.go checks
sofisl 57d53a1
docs: re-add exec to config schema
sofisl db650b9
Update internal/librarian/golang/format.go
sofisl 47f12ea
resolve conflicts
sofisl 5cb459b
chore: lint
sofisl 06b6aba
chore: respond to comments
sofisl 608f790
chore: lint
sofisl a8c9d28
chore: respond to 3rd round of comments
sofisl 4d48967
chore: update issue
sofisl 535c382
chore: update generated config schema doc
sofisl 028d287
refactor: remove redundant error wrapping, unexport and group package…
sofisl ed6120d
Merge branch 'main' into addGoToolsToConfigTools
sofisl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| # Copyright 2026 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # https://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
sofisl marked this conversation as resolved.
|
||
| # | ||
| # TODO(https://github.com/googleapis/librarian/issues/5449): move this file to | ||
| # github.com/googleapis/google-cloud-go after the repository has migrated to | ||
| # librarian. | ||
| language: go | ||
| tools: | ||
| go: | ||
| - name: github.com/googleapis/gapic-generator-go/cmd/protoc-gen-go_gapic | ||
| version: v0.58.0 | ||
| - name: golang.org/x/tools/cmd/goimports | ||
| version: v0.44.0 | ||
| - name: google.golang.org/grpc/cmd/protoc-gen-go-grpc | ||
| version: v1.3.0 | ||
| - name: google.golang.org/protobuf/cmd/protoc-gen-go | ||
| version: v1.36.11 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.