refactor(pubsub): return weak senders from lease loop#5460
Open
dbolduc wants to merge 1 commit intogoogleapis:mainfrom
Open
refactor(pubsub): return weak senders from lease loop#5460dbolduc wants to merge 1 commit intogoogleapis:mainfrom
dbolduc wants to merge 1 commit intogoogleapis:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5460 +/- ##
=======================================
Coverage 97.73% 97.74%
=======================================
Files 217 217
Lines 48177 48187 +10
=======================================
+ Hits 47085 47098 +13
+ Misses 1092 1089 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5255
LeaseLoopowns the shutdown behavior, instead of having the logic split between theMessageStreamand theLeaseLoop. Seems slightly cleaner.