Skip to content

chore(librarian): remove incomplete entry in config.yaml#16768

Merged
parthea merged 1 commit intomainfrom
parthea-patch-16
Apr 22, 2026
Merged

chore(librarian): remove incomplete entry in config.yaml#16768
parthea merged 1 commit intomainfrom
parthea-patch-16

Conversation

@parthea
Copy link
Copy Markdown
Contributor

@parthea parthea commented Apr 22, 2026

#16549 removed release_blocked for google-cloud-firestore. The generated_blocked was not removed however since id: google-cloud-firestore was removed in the PR, the generated_blocked remained in the config.yaml as an incorrect entry.

There is already an entry for google-cloud-firestore with generate_blocked here:

- generate_blocked: true
id: google-cloud-firestore

@parthea parthea requested a review from a team as a code owner April 22, 2026 20:11
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes an incomplete library entry from the .librarian/config.yaml configuration file. Feedback suggests that there are additional orphaned entries that should also be removed to ensure the configuration is thoroughly cleaned up, noting a potential discrepancy between the PR description and the specific line removed.

Comment thread .librarian/config.yaml
@parthea parthea merged commit 6614d4c into main Apr 22, 2026
30 checks passed
@parthea parthea deleted the parthea-patch-16 branch April 22, 2026 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants