chore(storage): update cloudbuild yaml to include cloudkms scope#16745
Merged
chore(storage): update cloudbuild yaml to include cloudkms scope#16745
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds the cloudkms scope to the VM configuration in the system tests Cloud Build file. Feedback suggests simplifying the --scopes list by removing redundant storage scopes that are already covered by full_control and recommends using the cloud-platform scope as a best practice.
| - "--image-project=debian-cloud" | ||
| - "--service-account=${_ZONAL_VM_SERVICE_ACCOUNT}" | ||
| - "--scopes=https://www.googleapis.com/auth/devstorage.full_control,https://www.googleapis.com/auth/devstorage.read_only,https://www.googleapis.com/auth/devstorage.read_write" | ||
| - "--scopes=https://www.googleapis.com/auth/devstorage.full_control,https://www.googleapis.com/auth/devstorage.read_only,https://www.googleapis.com/auth/devstorage.read_write,https://www.googleapis.com/auth/cloudkms" |
Contributor
There was a problem hiding this comment.
The storage scopes read_only and read_write are redundant because full_control already encompasses all storage permissions. Removing them simplifies the configuration. As a further improvement, consider using the cloud-platform scope, which is the recommended best practice for managing permissions via IAM roles.
- "--scopes=https://www.googleapis.com/auth/devstorage.full_control,https://www.googleapis.com/auth/cloudkms"
parthea
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
cloudkmsscope to the zb-cloudbuild.yaml file to enable KMS integration system tests for appendable objects.