-
Notifications
You must be signed in to change notification settings - Fork 1.7k
chore: complete migration of pandas-gbq #16739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+8
−11
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,13 @@ | ||
| { | ||
| "name": "pandas-gbq", | ||
| "name_pretty": "Google BigQuery connector for pandas", | ||
| "product_documentation": "https://cloud.google.com/bigquery", | ||
| "api_id": "bigquery.googleapis.com", | ||
| "client_documentation": "https://googleapis.dev/python/pandas-gbq/latest/", | ||
| "distribution_name": "pandas-gbq", | ||
| "issue_tracker": "https://github.com/googleapis/python-bigquery-pandas/issues", | ||
| "release_level": "preview", | ||
| "language": "python", | ||
| "library_type": "INTEGRATION", | ||
| "repo": "googleapis/google-cloud-python", | ||
| "distribution_name": "pandas-gbq", | ||
| "api_id": "bigquery.googleapis.com", | ||
| "default_version": "", | ||
| "codeowner_team": "@googleapis/cloud-sdk-python-team @googleapis/bigquery-dataframe-team" | ||
| } | ||
| "name": "pandas-gbq", | ||
| "name_pretty": "Google BigQuery connector for pandas", | ||
| "product_documentation": "https://cloud.google.com/bigquery", | ||
| "release_level": "preview", | ||
| "repo": "googleapis/google-cloud-python" | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
codeowner_teamfield was removed during the alphabetical reordering of keys. This field is essential for identifying the owners of the package for automated PR assignments and issue routing. Please restore it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gemini-code-assist
I have seen this comment about removal of
codeowner_teamfrom the.repo-metadate.jsonfile as being problematic on more than one occasion.For the record, in the
google-cloud-pythonrepo, we have moved away from using that field in this file to using a dedicated.github/CODEOWNERSfile.Please avoid this comment going forth for packages in the
google-cloud-pythonrepository.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the clarification, @chalmerlowe. I have noted that the
codeowner_teamfield is no longer required for packages within thegoogle-cloud-pythonrepository, as ownership is now managed via the.github/CODEOWNERSfile. I will adjust my review process accordingly for this repository.