Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion librarian.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4608,7 +4608,6 @@ libraries:
default_version: apiVersion
- name: pandas-gbq
version: 0.35.0
skip_generate: true
python:
library_type: INTEGRATION
name_pretty_override: Google BigQuery connector for pandas
Expand Down
18 changes: 8 additions & 10 deletions packages/pandas-gbq/.repo-metadata.json
Original file line number Diff line number Diff line change
@@ -1,15 +1,13 @@
{
"name": "pandas-gbq",
"name_pretty": "Google BigQuery connector for pandas",
"product_documentation": "https://cloud.google.com/bigquery",
"api_id": "bigquery.googleapis.com",
"client_documentation": "https://googleapis.dev/python/pandas-gbq/latest/",
"distribution_name": "pandas-gbq",
"issue_tracker": "https://github.com/googleapis/python-bigquery-pandas/issues",
"release_level": "preview",
"language": "python",
"library_type": "INTEGRATION",
"repo": "googleapis/google-cloud-python",
"distribution_name": "pandas-gbq",
"api_id": "bigquery.googleapis.com",
"default_version": "",
"codeowner_team": "@googleapis/cloud-sdk-python-team @googleapis/bigquery-dataframe-team"
}
"name": "pandas-gbq",
"name_pretty": "Google BigQuery connector for pandas",
"product_documentation": "https://cloud.google.com/bigquery",
"release_level": "preview",
"repo": "googleapis/google-cloud-python"
}
Comment on lines 1 to +13
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The codeowner_team field was removed during the alphabetical reordering of keys. This field is essential for identifying the owners of the package for automated PR assignments and issue routing. Please restore it.

Suggested change
{
"name": "pandas-gbq",
"name_pretty": "Google BigQuery connector for pandas",
"product_documentation": "https://cloud.google.com/bigquery",
"api_id": "bigquery.googleapis.com",
"client_documentation": "https://googleapis.dev/python/pandas-gbq/latest/",
"distribution_name": "pandas-gbq",
"issue_tracker": "https://github.com/googleapis/python-bigquery-pandas/issues",
"release_level": "preview",
"language": "python",
"library_type": "INTEGRATION",
"repo": "googleapis/google-cloud-python",
"distribution_name": "pandas-gbq",
"api_id": "bigquery.googleapis.com",
"default_version": "",
"codeowner_team": "@googleapis/cloud-sdk-python-team @googleapis/bigquery-dataframe-team"
}
"name": "pandas-gbq",
"name_pretty": "Google BigQuery connector for pandas",
"product_documentation": "https://cloud.google.com/bigquery",
"release_level": "preview",
"repo": "googleapis/google-cloud-python"
}
{
"api_id": "bigquery.googleapis.com",
"client_documentation": "https://googleapis.dev/python/pandas-gbq/latest/",
"codeowner_team": "@googleapis/cloud-sdk-python-team @googleapis/bigquery-dataframe-team",
"distribution_name": "pandas-gbq",
"issue_tracker": "https://github.com/googleapis/python-bigquery-pandas/issues",
"language": "python",
"library_type": "INTEGRATION",
"name": "pandas-gbq",
"name_pretty": "Google BigQuery connector for pandas",
"product_documentation": "https://cloud.google.com/bigquery",
"release_level": "preview",
"repo": "googleapis/google-cloud-python"
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gemini-code-assist

I have seen this comment about removal of codeowner_team from the .repo-metadate.json file as being problematic on more than one occasion.

For the record, in the google-cloud-python repo, we have moved away from using that field in this file to using a dedicated .github/CODEOWNERS file.

Please avoid this comment going forth for packages in the google-cloud-python repository.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the clarification, @chalmerlowe. I have noted that the codeowner_team field is no longer required for packages within the google-cloud-python repository, as ownership is now managed via the .github/CODEOWNERS file. I will adjust my review process accordingly for this repository.

Loading