perf(storage): implement fast-path for queue delivery in _StreamMultiplexer#16718
Open
zhixiangli wants to merge 1 commit intogoogleapis:mainfrom
Open
perf(storage): implement fast-path for queue delivery in _StreamMultiplexer#16718zhixiangli wants to merge 1 commit intogoogleapis:mainfrom
zhixiangli wants to merge 1 commit intogoogleapis:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request optimizes the delivery of items to multiple queues in the _stream_multiplexer.py module. It introduces a new _put_to_queues method that implements a fast path using put_nowait for available queues and a slow path with a timeout for full queues, reducing unnecessary overhead from asyncio.gather and coroutine yields when queues have capacity. The _recv_loop has been refactored to use this optimized delivery mechanism. I have no feedback to provide as there were no review comments to evaluate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR optimizes the message delivery logic in
_StreamMultiplexerto reduce latency and event loop overhead.Performance Improvements:
queue.put_nowait(item)for all target queues. For queues with available capacity, this is a synchronous operation that avoids:asyncio.wait_for._put_with_timeoutcoroutine. This bypasses the overhead ofasyncio.gather, which is now only used when multiple queues are full simultaneously.