chore: complete google-cloud-dns migration#16678
Merged
jskeet merged 3 commits intogoogleapis:mainfrom Apr 20, 2026
Merged
Conversation
Contributor
jskeet
commented
Apr 16, 2026
jskeet
commented
- Reformat with nox
- Enable generation with librarian
- Regenerate with librarian
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the configuration and metadata for the google-cloud-dns package, including enabling generation in librarian.yaml and cleaning up .repo-metadata.json. It also performs extensive linting and import reordering across the codebase to improve consistency. A review comment suggests restoring a blank line between third-party and local imports in _http.py to adhere to PEP 8 standards.
parthea
reviewed
Apr 16, 2026
jskeet
force-pushed
the
reformat-google-cloud-dns
branch
from
e37c9c2 to
ca272df
Compare
parthea
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.