-
Notifications
You must be signed in to change notification settings - Fork 1.5k
DONOTMERGE #14183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sushanb
wants to merge
1
commit into
googleapis:main
Choose a base branch
from
sushanb:aa_b
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
DONOTMERGE #14183
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -19,11 +19,16 @@ package bigtable | |||||||||
| import ( | ||||||||||
| "context" | ||||||||||
| "fmt" | ||||||||||
| "log" | ||||||||||
| "strings" | ||||||||||
| "sync" | ||||||||||
| "time" | ||||||||||
|
|
||||||||||
| internal "cloud.google.com/go/bigtable/internal/transport" | ||||||||||
| "google.golang.org/api/option" | ||||||||||
| "google.golang.org/api/option/internaloption" | ||||||||||
| "google.golang.org/grpc" | ||||||||||
| "google.golang.org/grpc/credentials/google" | ||||||||||
| "google.golang.org/grpc/peer" | ||||||||||
| ) | ||||||||||
|
|
||||||||||
|
|
@@ -117,3 +122,63 @@ func CheckDirectAccessSupported(ctx context.Context, project, instance, appProfi | |||||||||
|
|
||||||||||
| return isDirectPathUsed, nil | ||||||||||
| } | ||||||||||
|
|
||||||||||
| // CallSingleChannel connects to Bigtable using the DirectPath C2P scheme, | ||||||||||
| // and continuously maintains 200 in-flight Prime requests on the same channel | ||||||||||
| // until the provided context is canceled. | ||||||||||
| func CallSingleChannel(ctx context.Context, project, instance, appProfile, target string, requestsInFlight int) error { | ||||||||||
| fullInstanceName := fmt.Sprintf("projects/%s/instances/%s", project, instance) | ||||||||||
|
|
||||||||||
| log.Printf("Creating single channel to %s", target) | ||||||||||
|
|
||||||||||
| // 1. Create the gRPC Client | ||||||||||
| conn, err := grpc.NewClient(target, | ||||||||||
| grpc.WithCredentialsBundle(google.NewDefaultCredentials()), | ||||||||||
| ) | ||||||||||
| if err != nil { | ||||||||||
| return fmt.Errorf("failed to create client for C2P target %s: %w", target, err) | ||||||||||
| } | ||||||||||
| defer conn.Close() | ||||||||||
|
|
||||||||||
| // 2. Wrap it in the internal BigtableConn | ||||||||||
| btc := internal.NewBigtableConn(conn) | ||||||||||
|
|
||||||||||
| // 3. Maintain 200 in-flight requests continuously | ||||||||||
| log.Printf("Starting %d workers to maintain continuous in-flight Prime() requests...", requestsInFlight) | ||||||||||
|
|
||||||||||
| var wg sync.WaitGroup | ||||||||||
|
|
||||||||||
| for i := 0; i < requestsInFlight; i++ { | ||||||||||
| wg.Add(1) | ||||||||||
| go func(workerID int) { | ||||||||||
| defer wg.Done() | ||||||||||
|
|
||||||||||
| // Infinite loop to keep firing requests | ||||||||||
| for { | ||||||||||
| // Exit the loop if the parent context is canceled | ||||||||||
| select { | ||||||||||
| case <-ctx.Done(): | ||||||||||
| return | ||||||||||
| default: | ||||||||||
| } | ||||||||||
|
|
||||||||||
| // Execute a single request with its own 10s timeout | ||||||||||
| primeCtx, cancel := context.WithTimeout(ctx, 10*time.Second) | ||||||||||
| ffMd := createFeatureFlagsMD(true, false, true) | ||||||||||
| err := btc.Prime(primeCtx, fullInstanceName, appProfile, ffMd) | ||||||||||
| cancel() // Always cancel to prevent context leaks | ||||||||||
|
|
||||||||||
| if err != nil { | ||||||||||
| log.Printf("[Worker %d] Prime() failed: %v", workerID, err) | ||||||||||
| // Tiny backoff to prevent CPU thrashing if the connection fully drops | ||||||||||
|
Comment on lines
+172
to
+173
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The comment on line 173 indicates an intention to add a backoff, but it's not implemented. Without a backoff, the loop could spin and consume high CPU if
Suggested change
|
||||||||||
| } | ||||||||||
| } | ||||||||||
| }(i) | ||||||||||
| } | ||||||||||
|
|
||||||||||
| // 4. Block until the context is canceled and all workers exit | ||||||||||
| wg.Wait() | ||||||||||
|
|
||||||||||
| log.Println("Stopped maintaining requests. Exiting CallSingleChannel.") | ||||||||||
| return ctx.Err() | ||||||||||
| } | ||||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function comment hardcodes '200' as the number of in-flight requests. However, this is determined by the
requestsInFlightparameter. The comment should be updated to reflect that this value is configurable to avoid confusion.