Align Python fallback client with Rust CLI (#911)#1379
Open
Jatin-Shihora wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #911
This will remove the
--compatibility-mode(-c) flag and clean up how color output is handled in the CLI.The compatibility flag originally existed to mimic the output of the Unix
filecommand. Since that behavior effectively disappeared when themagicfield was removed in v0.6.1. Since then, the flag has only acted as a no-op alias for--no-colors. The Rust CLI never supported this flag, so removing it also brings both implementations closer in behavior. I tried keeping both the CLIs logical working same.Color handling has also been updated. Colors are now automatically disabled when stdout is not a TTY, which is same as how the Rust client behaves. The
--colorsand--no-colorsflags can still be used to explicitly override this behavior.Also, scripts using the Python fallback client that pass
-cor--compatibility-modewill now fail with a “No such option” error.