Skip to content

fix: MagikaResult.__post_init__ validation was never called #1371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pumpkin-bit wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: MagikaResult.__post_init__ validation was never called #1371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion python/src/magika/types/magika_result.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,9 @@ def __init__(
self._path = path
self._status = status
self._prediction = prediction
self._validate()

def __post_init__(self) -> None:
def _validate(self) -> None:
assert self._path is not None
if self._status == Status.OK:
if self._prediction is None:
Expand Down