-
Notifications
You must be signed in to change notification settings - Fork 3.1k
fix(runners): preserve initial session state keys during rewind #4845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
saiprasanth-git
wants to merge
9
commits into
google:main
Choose a base branch
from
saiprasanth-git:fix/preserve-initial-state-on-rewind
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+62
−5
Open
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
4146ab7
fix: preserve URL fragment as query params in _prepare_request_params
saiprasanth-git b899c49
test: add test for fragment key=value extraction in _prepare_request_…
saiprasanth-git e8eca1b
fix: parse URL fragment key=value pairs into query params
saiprasanth-git 9ba41af
test: add coverage for fragment params being extracted as query params
saiprasanth-git 71e49d5
fix: remove redundant outer if guard causing mypy syntax error
saiprasanth-git 0e7cc8d
fix: preserve initial session state keys during rewind Fixes #4839: …
saiprasanth-git 9501d23
Merge branch 'main' into fix/preserve-initial-state-on-rewind
saiprasanth-git 4182ab6
fix(runners): use set comprehension for keys_ever_in_event_deltas
saiprasanth-git a704672
Merge branch 'main' into fix/preserve-initial-state-on-rewind
rohityan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.