Skip to content

Fix Windows Build: Add /Zc:preprocessor, Pin Python 3.12, Fix constinit #6238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SriHarsha-23 wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −2
Open

Fix Windows Build: Add /Zc:preprocessor, Pin Python 3.12, Fix constinit #6238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d80f32
Fix Windows build: Add /Zc:preprocessor, pin Python 3.12, and fix con…
SriHarsha-23 Feb 17, 2026
04e29c9
Add missing Windows build configuration to .bazelrc
SriHarsha-23 Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .bazelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@ build:linux --define=xnn_enable_avx512amx=false
build:windows --cxxopt=/std:c++20
build:windows --host_cxxopt=/std:c++20
build:windows --copt=/w
# Fix MSVC preprocessor compatibility (Fixes MP_STATUS_MACROS_IMPL_REM error)
build:windows --copt=/Zc:preprocessor
build:windows --host_copt=/Zc:preprocessor
# Ensure stable Python version for Windows builds (Avoids Python 3.13 crash)
build:windows --repo_env=HERMETIC_PYTHON_VERSION=3.12
# For using M_* math constants on Windows with MSVC.
build:windows --copt=/D_USE_MATH_DEFINES
build:windows --host_copt=/D_USE_MATH_DEFINES
Expand Down
2 changes: 1 addition & 1 deletion mediapipe/gpu/gpu_service.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

namespace mediapipe {

const GraphService<GpuResources> kGpuService(
constinit const GraphService<GpuResources> kGpuService(
"kGpuService", GraphServiceBase::kAllowDefaultInitialization);

} // namespace mediapipe
2 changes: 1 addition & 1 deletion mediapipe/gpu/gpu_service.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ class GpuResources {
};
#endif // MEDIAPIPE_DISABLE_GPU

ABSL_CONST_INIT extern const GraphService<GpuResources> kGpuService;
ABSL_CONST_INIT extern constinit const GraphService<GpuResources> kGpuService;

} // namespace mediapipe

Expand Down