⚡ Make http_request tool async to prevent event loop blocking#3
⚡ Make http_request tool async to prevent event loop blocking#3
Conversation
This change refactors the `http_request` tool in `src/matilda_brain/tools/builtins/web.py` to use `aiohttp` instead of `urllib`. This prevents blocking the event loop when the tool is executed in an async context, improving overall responsiveness and concurrency. Benchmarks/Verification: - Verified that concurrent tasks (simulated heartbeat) continue to run while `http_request` is waiting for a response (using a 2s delay endpoint). - Existing unit tests updated to test async implementation and pass. Co-authored-by: mudcube <101564+mudcube@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Replaced blocking
urllibcalls with non-blockingaiohttpinhttp_requesttool.What:
http_requestfrom sync toasync def.urllib.request.urlopenwithaiohttp.ClientSession.aiohttpexceptions.tests/test_tools_builtin.pyto useAsyncMockandaiohttpmocking.Why:
Measured Improvement:
PR created automatically by Jules for task 14459885260212713423 started by @mudcube