Skip to content

unix/linux: support AT_HANDLE_{FID,CONNECTABLE,MNT_ID_UNIQUE}#269

Open
cyphar wants to merge 1 commit intogolang:masterfrom
cyphar:at-handle-flags
Open

unix/linux: support AT_HANDLE_{FID,CONNECTABLE,MNT_ID_UNIQUE}#269
cyphar wants to merge 1 commit intogolang:masterfrom
cyphar:at-handle-flags

Conversation

@cyphar
Copy link
Copy Markdown
Contributor

@cyphar cyphar commented Apr 14, 2026

AT_HANDLE_FID and AT_HANDLE_CONNECTABLE are just plain flag defintions.

However, AT_HANDLE_MNT_ID_UNIQUE requires some special handling because
it indicates that the mount ID pointer argument is actually a uint64.

Unfortunately, providing this information to the caller would require
changing the function signature (and a quick code search on GitHub found
several examples where this would break existing programs) so we instead
add a new function OpenByHandleAt64 that can return a uint64 mount ID.

Because it makes little sense to return truncated unique mount IDs,
AT_HANDLE_MNT_ID_UNIQUE is silently masked in the legacy OpenByHandleAt
wrapper. Note that passing this flag value to OpenByHandleAt before this
patch would actually cause stack corruption, so this will not regress
existing working programs (as such programs are already broken).

Fixes golang/go#78742

@gopherbot
Copy link
Copy Markdown
Contributor

This PR (HEAD: e82b5ed) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/766780.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/766780.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/766780.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

Message from Ian Lance Taylor:

Patch Set 2: Hold+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/766780.
After addressing review feedback, remember to publish your drafts!

AT_HANDLE_FID and AT_HANDLE_CONNECTABLE are just plain flag defintions.

However, AT_HANDLE_MNT_ID_UNIQUE requires some special handling because
it indicates that the mount ID pointer argument is actually a uint64.

Unfortunately, providing this information to the caller would require
changing the function signature (and a quick code search on GitHub found
several examples where this would break existing programs) so we instead
add a new function OpenByHandleAt64 that can return a uint64 mount ID.

Because it makes little sense to return truncated unique mount IDs,
AT_HANDLE_MNT_ID_UNIQUE is silently masked in the legacy OpenByHandleAt
wrapper. Note that passing this flag value to OpenByHandleAt before this
patch would actually cause stack corruption, so this will not regress
existing working programs (as such programs are already broken).
@gopherbot
Copy link
Copy Markdown
Contributor

This PR (HEAD: 5595394) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/766780.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Copy Markdown
Contributor

Message from Aleksa Sarai:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/766780.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

proposal: x/sys/unix: support 64-bit mount IDs in NameToHandleAt

2 participants