Skip to content

Fix cargo build -p geo_filters --features serde #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jorendorff wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix cargo build -p geo_filters --features serde #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22c8678
Fix `cargo build -p geo_filters --features serde`
jorendorff Mar 10, 2026
133dca8
Add `make test` steps that would have caught this
jorendorff Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@ test:
RUST_BACKTRACE=1 cargo test
# Amazingly, `--all-targets` causes doc-tests not to run.
RUST_BACKTRACE=1 cargo test --doc
# Check that geo_filters compiles with each feature in isolation and with no features
cargo check -p geo_filters --no-default-features
cargo check -p geo_filters --features test-support
cargo check -p geo_filters --features serde
cargo check -p geo_filters --features evaluation
Comment on lines +37 to +39
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment says each feature is compiled “in isolation”, but the per-feature cargo check commands don’t pass --no-default-features. That’s equivalent today because default = [], but if default features are added later these checks will no longer validate isolation. Consider adding --no-default-features to the test-support/serde/evaluation checks as well (or updating the comment).

Suggested change
cargo check -p geo_filters --features test-support
cargo check -p geo_filters --features serde
cargo check -p geo_filters --features evaluation
cargo check -p geo_filters --no-default-features --features test-support
cargo check -p geo_filters --no-default-features --features serde
cargo check -p geo_filters --no-default-features --features evaluation

Copilot uses AI. Check for mistakes.

.PHONY: test-ignored
test-ignored:
Expand Down
4 changes: 2 additions & 2 deletions crates/geo_filters/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "geo_filters"
version = "0.1.0"
version = "0.1.1"
edition = "2021"
description = "Geometric filters for set cardinality estimation."
repository = "https://github.com/github/rust-gems"
Expand Down Expand Up @@ -33,7 +33,7 @@ once_cell = "1.18"
rand = { version = "0.9", optional = true }
rayon = { version = "1.7", optional = true }
regex = { version = "1", optional = true }
serde = { version = "1.0", default-features = false, optional = true }
serde = { version = "1.0", default-features = false, features = ["derive"], optional = true }
rand_chacha = { version = "0.9", optional = true }

[dev-dependencies]
Expand Down
Loading