[Node] Add Support For Commands and Simple UI#873
[Node] Add Support For Commands and Simple UI#873MRayermannMSFT wants to merge 1 commit intomainfrom
Conversation
Cross-SDK Consistency ReviewThank you for this PR! I've reviewed the changes for consistency across all four SDK implementations (Node.js, Python, Go, .NET). This PR adds two significant new features to the Node.js SDK:
🔍 Findings✅ Event Infrastructure Exists (All SDKs)All SDKs already support the underlying event infrastructure:
|
| }); | ||
|
|
||
| describe("commands in session creation", () => { | ||
| it("forwards commands metadata in session.create request", async () => { |
There was a problem hiding this comment.
I was about to ask for these mock-based tests to be replaced with E2E ones, but is that actually possible? My guess is it would only be possible if there's also a way to trigger commands from an SDK client. Right now we may be lacking that and only the CLI can trigger them. Is that right?
Of course I understand that for elicitation, it would only be possible to have an E2E test if there was also some UI implementation we can observe, which I don't think will be the case from this repo.
No description provided.