Add newtypes for ELF constants#894
Open
philipc wants to merge 20 commits intogimli-rs:mainfrom
Open
Conversation
This includes the SHF constants.
Also changes elf::DF_* constants to u64.
Also removes unneeded VERSYM_HIDDEN masking for vd_ndx and vna_other.
Avoids sharing name with elf::AttributeTag.
Also add elf::SectionIndex::new+index
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking changes:
build::elf::AttributesSubsubsection::tagtoscope.build::elf::AttributeTagtoAttributeScope.read::elf::VersionIndexwithelf::VersymIndexandelf::VersionIndex.read::elf::Dyn::Sword.DynamicTagis alwaysi64.elf::SHF_*constants changed fromu32toSectionFlags(u64).elf::DF_*constants changed fromu32toDynamicFlags(u64).Additionally, we no longer mask
VERSYM_HIDDENforvd_ndxandvna_other. This should never be set for these fields. Masking can be added back if it turns out to be encountered in practice.