feat(asgi): Migrate away from event processor in span first #5920
1 issue
code-review: Found 1 issue (1 medium)
Medium
StreamedSpan name and source not updated on exception path - `sentry_sdk/integrations/asgi.py:349-357`
When the ASGI app raises an exception, the code to update the StreamedSpan name and source (lines 349-355) is skipped because it's only in the success path. This means error spans will have the generic initial transaction name instead of the resolved endpoint/URL name. The event processor handled this for traditional transactions, but the PR description states span-first mode has no event processors, leaving error spans with incomplete data.
Duration: 2m 40s · Tokens: 606.6k in / 7.6k out · Cost: $0.87 (+extraction: $0.00, +fix_gate: $0.00)
Annotations
Check warning on line 357 in sentry_sdk/integrations/asgi.py
sentry-warden / warden: code-review
StreamedSpan name and source not updated on exception path
When the ASGI app raises an exception, the code to update the `StreamedSpan` name and source (lines 349-355) is skipped because it's only in the success path. This means error spans will have the generic initial transaction name instead of the resolved endpoint/URL name. The event processor handled this for traditional transactions, but the PR description states span-first mode has no event processors, leaving error spans with incomplete data.