Skip to content

Merge branch 'master' into fix/flaky-continuous-profiler-gevent-test

b746060
Select commit
Loading
Failed to load commit list.
Open

fix(tests): Fix flaky continuous profiler test under gevent #5899

Merge branch 'master' into fix/flaky-continuous-profiler-gevent-test
b746060
Select commit
Loading
Failed to load commit list.
@sentry/warden / warden completed Mar 27, 2026 in 36s

1 issue

Low

Polling loop may use stale items if profile chunks arrive after timeout check - `tests/profiler/test_continuous_profiler.py:153-159`

The polling loop in assert_single_transaction_with_profile_chunks exits when the deadline is reached, but the items variable used for subsequent assertions reflects the state at the last poll iteration. If profile chunks arrive between the final timeout check (line 157) and the assertion (line 162), the test will fail despite chunks being present. This is a narrow race window but could still contribute to flakiness rather than eliminating it.

4 skills analyzed
Skill Findings Duration Cost
code-review 0 27.4s $0.09
find-bugs 1 30.7s $0.13
skill-scanner 0 13.9s $0.07
security-review 0 17.7s $0.08

Duration: 1m 30s · Tokens: 142.8k in / 3.1k out · Cost: $0.38 (+extraction: $0.00, +fix_gate: $0.00)