Skip to content

ci: Skip test suite when no code files changed #5889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
stephanie-anderson wants to merge 5 commits into
base: master
Choose a base branch
from

ci: Also skip tests on push when no code files changed

ec091a1
Select commit
Loading
Failed to load commit list.
Draft

ci: Skip test suite when no code files changed #5889

ci: Also skip tests on push when no code files changed
ec091a1
Select commit
Loading
Failed to load commit list.
@sentry/warden / warden: code-review completed Mar 26, 2026 in 4m 47s

1 issue

code-review: Found 1 issue (1 high)

High

Tests on master/release/major branches can be incorrectly skipped - `.github/workflows/test-integrations-ai.yml:51`

The PR description states 'Pushes to master/release//major/ branches always run the full suite', but the test job's if condition (line 51) only checks needs.changes.outputs.has_code_changes == 'true' without considering the branch. This means pushes to protected branches that contain only non-code changes (e.g., a merge commit touching only docs) will skip tests, violating the stated requirement. The condition should include a bypass for push events to these protected branches.

Also found at:

  • .github/workflows/ci.yml:44
  • .github/workflows/test-integrations-agents.yml:51
  • .github/workflows/test-integrations-cloud.yml:51
  • .github/workflows/test-integrations-common.yml:51
  • .github/workflows/test-integrations-dbs.yml:51
  • .github/workflows/test-integrations-gevent.yml:51
  • .github/workflows/test-integrations-graphql.yml:51
  • .github/workflows/test-integrations-mcp.yml:51
  • .github/workflows/test-integrations-network.yml:51
  • .github/workflows/test-integrations-tasks.yml:51
  • .github/workflows/test-integrations-web-1.yml:51
  • .github/workflows/test-integrations-web-2.yml:51
  • .github/workflows/test-integrations-flags.yml:51
  • scripts/split_tox_gh_actions/templates/base.jinja:36-56

Duration: 4m 41s · Tokens: 2.7M in / 49.6k out · Cost: $4.70 (+extraction: $0.01, +merge: $0.00, +fix_gate: $0.00)

Annotations

Check failure on line 51 in .github/workflows/test-integrations-ai.yml

See this annotation in the file changed.

@sentry-warden sentry-warden / warden: code-review

Tests on master/release/major branches can be incorrectly skipped 

The PR description states 'Pushes to master/release/**/major/** branches always run the full suite', but the test job's `if` condition (line 51) only checks `needs.changes.outputs.has_code_changes == 'true'` without considering the branch. This means pushes to protected branches that contain only non-code changes (e.g., a merge commit touching only docs) will skip tests, violating the stated requirement. The condition should include a bypass for push events to these protected branches.

Check failure on line 44 in .github/workflows/ci.yml

See this annotation in the file changed.

@sentry-warden sentry-warden / warden: code-review

[G7J-P8F] Tests on master/release/major branches can be incorrectly skipped (additional location) 

The PR description states 'Pushes to master/release/**/major/** branches always run the full suite', but the test job's `if` condition (line 51) only checks `needs.changes.outputs.has_code_changes == 'true'` without considering the branch. This means pushes to protected branches that contain only non-code changes (e.g., a merge commit touching only docs) will skip tests, violating the stated requirement. The condition should include a bypass for push events to these protected branches.

Check failure on line 51 in .github/workflows/test-integrations-agents.yml

See this annotation in the file changed.

@sentry-warden sentry-warden / warden: code-review

[G7J-P8F] Tests on master/release/major branches can be incorrectly skipped (additional location) 

The PR description states 'Pushes to master/release/**/major/** branches always run the full suite', but the test job's `if` condition (line 51) only checks `needs.changes.outputs.has_code_changes == 'true'` without considering the branch. This means pushes to protected branches that contain only non-code changes (e.g., a merge commit touching only docs) will skip tests, violating the stated requirement. The condition should include a bypass for push events to these protected branches.

Check failure on line 51 in .github/workflows/test-integrations-cloud.yml

See this annotation in the file changed.

@sentry-warden sentry-warden / warden: code-review

[G7J-P8F] Tests on master/release/major branches can be incorrectly skipped (additional location) 

The PR description states 'Pushes to master/release/**/major/** branches always run the full suite', but the test job's `if` condition (line 51) only checks `needs.changes.outputs.has_code_changes == 'true'` without considering the branch. This means pushes to protected branches that contain only non-code changes (e.g., a merge commit touching only docs) will skip tests, violating the stated requirement. The condition should include a bypass for push events to these protected branches.

Check failure on line 51 in .github/workflows/test-integrations-common.yml

See this annotation in the file changed.

@sentry-warden sentry-warden / warden: code-review

[G7J-P8F] Tests on master/release/major branches can be incorrectly skipped (additional location) 

The PR description states 'Pushes to master/release/**/major/** branches always run the full suite', but the test job's `if` condition (line 51) only checks `needs.changes.outputs.has_code_changes == 'true'` without considering the branch. This means pushes to protected branches that contain only non-code changes (e.g., a merge commit touching only docs) will skip tests, violating the stated requirement. The condition should include a bypass for push events to these protected branches.

Check failure on line 51 in .github/workflows/test-integrations-dbs.yml

See this annotation in the file changed.

@sentry-warden sentry-warden / warden: code-review

[G7J-P8F] Tests on master/release/major branches can be incorrectly skipped (additional location) 

The PR description states 'Pushes to master/release/**/major/** branches always run the full suite', but the test job's `if` condition (line 51) only checks `needs.changes.outputs.has_code_changes == 'true'` without considering the branch. This means pushes to protected branches that contain only non-code changes (e.g., a merge commit touching only docs) will skip tests, violating the stated requirement. The condition should include a bypass for push events to these protected branches.

Check failure on line 51 in .github/workflows/test-integrations-gevent.yml

See this annotation in the file changed.

@sentry-warden sentry-warden / warden: code-review

[G7J-P8F] Tests on master/release/major branches can be incorrectly skipped (additional location) 

The PR description states 'Pushes to master/release/**/major/** branches always run the full suite', but the test job's `if` condition (line 51) only checks `needs.changes.outputs.has_code_changes == 'true'` without considering the branch. This means pushes to protected branches that contain only non-code changes (e.g., a merge commit touching only docs) will skip tests, violating the stated requirement. The condition should include a bypass for push events to these protected branches.

Check failure on line 51 in .github/workflows/test-integrations-graphql.yml

See this annotation in the file changed.

@sentry-warden sentry-warden / warden: code-review

[G7J-P8F] Tests on master/release/major branches can be incorrectly skipped (additional location) 

The PR description states 'Pushes to master/release/**/major/** branches always run the full suite', but the test job's `if` condition (line 51) only checks `needs.changes.outputs.has_code_changes == 'true'` without considering the branch. This means pushes to protected branches that contain only non-code changes (e.g., a merge commit touching only docs) will skip tests, violating the stated requirement. The condition should include a bypass for push events to these protected branches.

Check failure on line 51 in .github/workflows/test-integrations-mcp.yml

See this annotation in the file changed.

@sentry-warden sentry-warden / warden: code-review

[G7J-P8F] Tests on master/release/major branches can be incorrectly skipped (additional location) 

The PR description states 'Pushes to master/release/**/major/** branches always run the full suite', but the test job's `if` condition (line 51) only checks `needs.changes.outputs.has_code_changes == 'true'` without considering the branch. This means pushes to protected branches that contain only non-code changes (e.g., a merge commit touching only docs) will skip tests, violating the stated requirement. The condition should include a bypass for push events to these protected branches.

Check failure on line 51 in .github/workflows/test-integrations-network.yml

See this annotation in the file changed.

@sentry-warden sentry-warden / warden: code-review

[G7J-P8F] Tests on master/release/major branches can be incorrectly skipped (additional location) 

The PR description states 'Pushes to master/release/**/major/** branches always run the full suite', but the test job's `if` condition (line 51) only checks `needs.changes.outputs.has_code_changes == 'true'` without considering the branch. This means pushes to protected branches that contain only non-code changes (e.g., a merge commit touching only docs) will skip tests, violating the stated requirement. The condition should include a bypass for push events to these protected branches.

Check failure on line 51 in .github/workflows/test-integrations-tasks.yml

See this annotation in the file changed.

@sentry-warden sentry-warden / warden: code-review

[G7J-P8F] Tests on master/release/major branches can be incorrectly skipped (additional location) 

The PR description states 'Pushes to master/release/**/major/** branches always run the full suite', but the test job's `if` condition (line 51) only checks `needs.changes.outputs.has_code_changes == 'true'` without considering the branch. This means pushes to protected branches that contain only non-code changes (e.g., a merge commit touching only docs) will skip tests, violating the stated requirement. The condition should include a bypass for push events to these protected branches.

Check failure on line 51 in .github/workflows/test-integrations-web-1.yml

See this annotation in the file changed.

@sentry-warden sentry-warden / warden: code-review

[G7J-P8F] Tests on master/release/major branches can be incorrectly skipped (additional location) 

The PR description states 'Pushes to master/release/**/major/** branches always run the full suite', but the test job's `if` condition (line 51) only checks `needs.changes.outputs.has_code_changes == 'true'` without considering the branch. This means pushes to protected branches that contain only non-code changes (e.g., a merge commit touching only docs) will skip tests, violating the stated requirement. The condition should include a bypass for push events to these protected branches.

Check failure on line 51 in .github/workflows/test-integrations-web-2.yml

See this annotation in the file changed.

@sentry-warden sentry-warden / warden: code-review

[G7J-P8F] Tests on master/release/major branches can be incorrectly skipped (additional location) 

The PR description states 'Pushes to master/release/**/major/** branches always run the full suite', but the test job's `if` condition (line 51) only checks `needs.changes.outputs.has_code_changes == 'true'` without considering the branch. This means pushes to protected branches that contain only non-code changes (e.g., a merge commit touching only docs) will skip tests, violating the stated requirement. The condition should include a bypass for push events to these protected branches.

Check failure on line 51 in .github/workflows/test-integrations-flags.yml

See this annotation in the file changed.

@sentry-warden sentry-warden / warden: code-review

[G7J-P8F] Tests on master/release/major branches can be incorrectly skipped (additional location) 

The PR description states 'Pushes to master/release/**/major/** branches always run the full suite', but the test job's `if` condition (line 51) only checks `needs.changes.outputs.has_code_changes == 'true'` without considering the branch. This means pushes to protected branches that contain only non-code changes (e.g., a merge commit touching only docs) will skip tests, violating the stated requirement. The condition should include a bypass for push events to these protected branches.

Check failure on line 56 in scripts/split_tox_gh_actions/templates/base.jinja

See this annotation in the file changed.

@sentry-warden sentry-warden / warden: code-review

[G7J-P8F] Tests on master/release/major branches can be incorrectly skipped (additional location) 

The PR description states 'Pushes to master/release/**/major/** branches always run the full suite', but the test job's `if` condition (line 51) only checks `needs.changes.outputs.has_code_changes == 'true'` without considering the branch. This means pushes to protected branches that contain only non-code changes (e.g., a merge commit touching only docs) will skip tests, violating the stated requirement. The condition should include a bypass for push events to these protected branches.
View more details on @sentry/warden