feat(anthropic): Emit AI Client Spans for synchronous messages.stream()
#5565
2 issues
code-review: Found 2 issues (2 low)
Low
Test missing GEN_AI_SYSTEM assertion - `tests/integrations/anthropic/test_anthropic.py:417-422`
The new test_stream_messages test is missing the assertion assert span["data"][SPANDATA.GEN_AI_SYSTEM] == "anthropic" which is present in the similar test_streaming_create_message test (line 306) and other streaming tests. This reduces test coverage - if the integration stops setting the system identifier, this test won't catch it.
Also found at:
tests/integrations/anthropic/test_anthropic.py:1791-1794
Malformed comment from copy-paste error - `tests/integrations/anthropic/test_anthropic.py:2919`
The comment on line 2919 contains a copy-paste error: 'test_stream_messages_input_tokens_include_cache_read_streaming' was accidentally included instead of the expected value '2865'. This appears to be leftover from when the new test function was created. The comment should match line 2985 which correctly states '= 2865'.
Duration: 3m 31s · Tokens: 1.4M in / 17.0k out · Cost: $2.09 (+extraction: $0.01, +merge: $0.00, +fix_gate: $0.00)