Skip to content

Non-routable option not working#102

Open
simmonsr wants to merge 3 commits intogetgrav:developfrom
simmonsr:patch-1
Open

Non-routable option not working#102
simmonsr wants to merge 3 commits intogetgrav:developfrom
simmonsr:patch-1

Conversation

@simmonsr
Copy link
Copy Markdown

When selecting Routable: disabled with Antimatter, it has no effect. The following change fixes the issue.

When selecting Routable: disabled with Antimatter, it has no effect. The following change fixes the issue.
@rhukster
Copy link
Copy Markdown
Member

I can see the issue that a routable page (should be in menu, can't reach the page) could be handled better in Antimatter (all themes probably), but I think it can be done with a lot less copy/paste style code. In fact a non-routable page should have no <a> at all, and should use a <span>, but these means some tweaks to the scss also.

@simmonsr
Copy link
Copy Markdown
Author

simmonsr commented Mar 28, 2017

I can just create an issue for the theme if you would prefer. Currently Routable: Disabled simply does not work w/ antimatter. It continues to be routable.

But yes, I agree it should use span and if there is smoother option than great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants