Open
Conversation
Use PageTitleAPI for PageTitle creation Use MetaTagManagerRegistry for MetaTag creation Make Twitter site property not mandatory for Twitter card usage Add Twitter title/description/image per default
georgringer
requested changes
Feb 4, 2019
Owner
georgringer
left a comment
georgringer
left a comment
There was a problem hiding this comment.
You need to support typo3 8 still ;))
added 3 commits
February 4, 2019 13:00
Support 8 LTS
Support 8 LTS
Skip titleTagIsSet Test for TYPO3 9
Contributor
|
can this be rebased please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use PageTitleAPI for PageTitle creation
Use MetaTagManagerRegistry for MetaTag creation
Make Twitter site property not mandatory for Twitter card usage
Add Twitter title/description/image per default