[BUGFIX] Fix record overlay for 'List of selected items' (2369)#2474
Open
idleworks wants to merge 1 commit intogeorgringer:mainfrom
Open
[BUGFIX] Fix record overlay for 'List of selected items' (2369)#2474idleworks wants to merge 1 commit intogeorgringer:mainfrom
idleworks wants to merge 1 commit intogeorgringer:mainfrom
Conversation
georgringer
requested changes
May 17, 2024
| // Id list | ||
| $idList = $demand->getIdList(); | ||
| if ($idList) { | ||
| $query->getQuerySettings()->setRespectStoragePage(false); |
Owner
There was a problem hiding this comment.
this is not needed as already set in generateQuery()
| $idList = $demand->getIdList(); | ||
| if ($idList) { | ||
| $query->getQuerySettings()->setRespectStoragePage(false); | ||
| $query->getQuerySettings()->setRespectSysLanguage(false); |
Owner
There was a problem hiding this comment.
why not set $disableLanguageOverlayMode to true in the selectedListAction call?
| if ($idList) { | ||
| $query->getQuerySettings()->setRespectStoragePage(false); | ||
| $query->getQuerySettings()->setRespectSysLanguage(false); | ||
| $query->getQuerySettings()->setLanguageOverlayMode(true); |
Owner
There was a problem hiding this comment.
I would also move that out of this important method which is used by all actions and make if configurable from the action. what do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2369