fix(node): update strings guide for three translation approaches#273
Open
moss-bryophyta wants to merge 1 commit intogeneraltranslation:mainfrom
Open
fix(node): update strings guide for three translation approaches#273moss-bryophyta wants to merge 1 commit intogeneraltranslation:mainfrom
moss-bryophyta wants to merge 1 commit intogeneraltranslation:mainfrom
Conversation
- description: "Two approaches" → "Three approaches" (tx() was added) - callout: "Both approaches" → clarify getGT() and msg()/getMessages() are build-time, tx() is runtime - fix msg() link: /docs/node/api/get-messages → /docs/node/api/strings/msg (correct page)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Node.js strings guide was written when there were two translation approaches (
getGT()andmsg()/getMessages()). Aftertx()was added, the frontmatter description and a callout still said "two" / "both."Changes:
getGT()andmsg()/getMessages()are build-time equivalents, whiletx()is for runtimemsg()link: pointed to/docs/node/api/get-messages(thegetMessagespage) →/docs/node/api/strings/msg(the correctmsgpage)