fix(selectivity): dont lose data on page navigate by KuznetsovRoman · Pull Request #1227 · gemini-testing/testplane

KuznetsovRoman · 2026-03-31T23:46:26Z

No description provided.

pkg-pr-new · 2026-03-31T23:48:13Z

npm i https://pkg.pr.new/gemini-testing/testplane@1227

commit: 204f0e4

KuznetsovRoman · 2026-03-31T23:50:10Z

src/browser/cdp/index.ts

        switch (domain) {
            case "Target":
-                this.target.emit(method, cdpEventMessage.params);
+                this.target.emit(method, cdpEventMessage.params, cdpEventMessage.sessionId);


All events now also emit "sessionId" of events, if provided.
It helps to scope events and only handle those, which were emitted by our subscription

KuznetsovRoman · 2026-03-31T23:52:13Z

src/browser/cdp/selectivity/index.ts

+    await Promise.all([
+        cdp.dom.enable(sessionId).then(() => cdp.css.enable(sessionId)),
+        cdp.target.setAutoAttach(sessionId, { autoAttach: true, waitForDebuggerOnStart: false }),
+        cdp.debugger.enable(sessionId),
+        cdp.page.enable(sessionId),
+        cdp.profiler.enable(sessionId),
+    ]);


Moved all domain enables here from "js-selectivity" and "css-selectivity" so we can wait them all at once

KuznetsovRoman · 2026-03-31T23:58:36Z

src/browser/cdp/selectivity/index.ts

+        if (callFrames[0]?.functionName !== testplaneCoverageBreakScriptName) {
+            cdp.debugger.resume(sessionId).catch(() => {});
+            return;
+        }


In case its not our breakpoint, just resume the execution

KuznetsovRoman · 2026-03-31T23:59:03Z

src/browser/cdp/selectivity/index.ts

        }
    });

+    let pageSwitchPromise: Promise<void> = Promise.resolve();


As CDP might clean script data when switching pages, we solve the issue like this:

Call for "debugger" on page "beforeunload" event
It stops browser's V8
While V8 is stopped, take incremental snapshot of JS and CSS coverage
Wait for selectivity assets to load (they will be unable to download on page swtich)
Resume V8

KuznetsovRoman · 2026-03-31T23:59:46Z

src/browser/cdp/selectivity/index.ts

+            return;
+        }
+
+        pageSwitchPromise = pageSwitchPromise.finally(() =>


Saved to promise so we can await it before dependencies recording stops

KuznetsovRoman · 2026-04-01T00:00:51Z

src/browser/cdp/selectivity/index.ts

-        const [cssDependencies, jsDependencies] = await Promise.all([
+        await pageSwitchPromise;
+
+        const [cssDependenciesPromise, jsDependenciesPromise] = await Promise.allSettled([


Switched to "allSettled" because its important to unsubscribe from "debugger paused"

pageSwitchPromise can't throw either

KuznetsovRoman · 2026-04-01T00:02:00Z

src/browser/cdp/selectivity/js-selectivity.ts

-            return this._cdp.debugger.resume(this._sessionId).catch(() => {});
-        });
+    // If we haven't got "scriptParsed" event for the script, pull up source code + source map manually
+    private _ensureScriptsAreLoading(coverage: CDPScriptCoverage[]): void {


Moved original L137 - L207 to separate method. No changes

KuznetsovRoman · 2026-04-01T00:02:25Z

src/browser/cdp/selectivity/js-selectivity.ts

+            Promise.allSettled(Object.values(this._scriptsSource)),
+            Promise.allSettled(Object.values(this._scriptsSourceMap)),


Errors will be handled on "stop" call

KuznetsovRoman · 2026-04-01T00:03:00Z

src/browser/cdp/selectivity/css-selectivity.ts

    }

+    // If we haven't got "styleSheetAdded" event for the script, pull up styles + source map manually
+    private _ensureStylesAreLoading(ruleUsage: CSSRuleUsage[]): void {


Moved original L106 - L155 to separate method. No changes

KuznetsovRoman · 2026-04-01T00:03:21Z

src/browser/cdp/selectivity/css-selectivity.ts

+    }
+
+    private async _waitForLoadingStyles(): Promise<void> {
+        await Promise.allSettled(Object.values(this._stylesSourceMap));


Errors are handled on "stop" call

KuznetsovRoman · 2026-04-01T09:09:30Z

src/browser/cdp/selectivity/css-selectivity.ts

+        { header: { styleSheetId, sourceURL, sourceMapURL } }: CssEvents["styleSheetAdded"],
+        cdpSessionId?: CDPSessionId,
+    ): void {
+        if (!this._sessionId || cdpSessionId !== this._sessionId) {


Avoid handling styles for different sessions
Just in case user is subscribed to "css" in another target

KuznetsovRoman · 2026-04-01T12:30:18Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1fd584da12

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-01T12:38:08Z

src/browser/cdp/selectivity/index.ts

+
+    cdp.debugger.on("paused", debuggerPausedFn);
+
+    await cdp.page.addScriptToEvaluateOnNewDocument(sessionId, { source: scriptToEvaluateOnNewDocument });


Remove injected beforeunload script during selectivity teardown

startSelectivity adds a new Page.addScriptToEvaluateOnNewDocument handler on every test run, but teardown never calls Page.removeScriptToEvaluateOnNewDocument. Because this API stores scripts in a persistent list for the target, long-lived browser sessions will accumulate duplicate beforeunload listeners, causing multiple debugger pauses/snapshots per navigation and progressively slower or flaky runs.

Useful? React with 👍 / 👎.

We dont have to do it because session is detached in returned stop function like this: cdp.target.detachFromTarget(sessionId).catch(() => {});

For other new tests we would have new cdp target id

chatgpt-codex-connector · 2026-04-01T12:38:08Z

src/browser/cdp/selectivity/js-selectivity.ts

+        this._ensureScriptsAreLoading(coveragePart.result);

-                        return sourceMap;
-                    } catch (err) {
-                        return err as Error;
-                    }
-                });
-            });
+        await this._waitForLoadingScripts();


Avoid blocking paused navigation on source-map loading

takeCoverageSnapshot now waits for _waitForLoadingScripts() to settle before returning, and this function is called from the Debugger.paused handler before Debugger.resume. In pages with slow/unreachable source-map URLs, navigation stays paused until those fetches settle, which can turn ordinary page transitions into command timeouts.

Useful? React with 👍 / 👎.

Thats the point: switching page erases those scripts from v8

KuznetsovRoman added 2 commits April 1, 2026 02:44

feat(cdp): describe fetch/network/page domains

970fe36

feat(cdp): emit events with session id

4e9a157

KuznetsovRoman force-pushed the TESTPLANE-961.selectivity_support_page_switch branch from 4772fe7 to 1fd584d Compare March 31, 2026 23:56

KuznetsovRoman commented Apr 1, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Apr 1, 2026

View reviewed changes

fix(selectivity): dont lose data on page navigate

204f0e4

KuznetsovRoman force-pushed the TESTPLANE-961.selectivity_support_page_switch branch from 1fd584d to 204f0e4 Compare April 1, 2026 13:00

sipayRT approved these changes Apr 1, 2026

View reviewed changes

KuznetsovRoman merged commit 03e7b8a into master Apr 1, 2026
7 checks passed

KuznetsovRoman deleted the TESTPLANE-961.selectivity_support_page_switch branch April 1, 2026 13:16

		Promise.allSettled(Object.values(this._scriptsSource)),
		Promise.allSettled(Object.values(this._scriptsSourceMap)),


		cdp.debugger.on("paused", debuggerPausedFn);

		await cdp.page.addScriptToEvaluateOnNewDocument(sessionId, { source: scriptToEvaluateOnNewDocument });

Conversation

KuznetsovRoman commented Mar 31, 2026

Uh oh!

pkg-pr-new bot commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KuznetsovRoman commented Apr 1, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

pkg-pr-new bot commented Mar 31, 2026 •

edited

Loading