Skip to content

Fix release CI#1919

Merged
ISSOtm merged 8 commits into
gbdev:masterfrom
ISSOtm:release-ci
Apr 8, 2026
Merged

Fix release CI#1919
ISSOtm merged 8 commits into
gbdev:masterfrom
ISSOtm:release-ci

Conversation

@ISSOtm
Copy link
Copy Markdown
Member

@ISSOtm ISSOtm commented Apr 7, 2026

This was tested by pushing tags to this repo, since there are secrets and other interactions that can only be done on the gbdev/ repo.

@ISSOtm ISSOtm requested a review from Rangi42 April 7, 2026 22:32
@ISSOtm ISSOtm added the builds This affects the build process or release artifacts label Apr 7, 2026
@Rangi42 Rangi42 added this to the 1.0.2 milestone Apr 7, 2026
Rangi42
Rangi42 previously requested changes Apr 7, 2026
Comment thread .github/workflows/create-release-artifacts.yml
Comment thread .github/workflows/create-release-artifacts.yml Outdated
Comment thread .github/workflows/create-release-artifacts.yml
Comment thread .github/workflows/create-release-artifacts.yml Outdated
ISSOtm added 2 commits April 8, 2026 01:57
This is a malware distrib vector,
and we run this workflow sporadically enough
that we can afford to do so uncached.
It was also vulnerable to template injection attacks.
ISSOtm added a commit to ISSOtm/rgbds that referenced this pull request Apr 7, 2026
@ISSOtm ISSOtm dismissed Rangi42’s stale review April 8, 2026 00:00

Changes applied.

@ISSOtm ISSOtm requested a review from Rangi42 April 8, 2026 00:00
Rangi42
Rangi42 previously requested changes Apr 8, 2026
Comment thread .github/scripts/draft-release.sh
Comment thread .github/workflows/create-release-artifacts.yml
Comment thread .github/scripts/draft-release.sh Outdated
Comment thread .github/scripts/draft-release.sh Outdated
ISSOtm added a commit to ISSOtm/rgbds that referenced this pull request Apr 8, 2026
@ISSOtm ISSOtm dismissed Rangi42’s stale review April 8, 2026 00:37

Changes applied.

@ISSOtm ISSOtm requested a review from Rangi42 April 8, 2026 00:37
Copy link
Copy Markdown
Contributor

@Rangi42 Rangi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more wafer-thin comment. :P

Comment thread .github/scripts/draft-release.sh Outdated
ISSOtm added 3 commits April 8, 2026 12:25
@ISSOtm ISSOtm merged commit ace2f3e into gbdev:master Apr 8, 2026
@ISSOtm ISSOtm deleted the release-ci branch April 8, 2026 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

builds This affects the build process or release artifacts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants