Skip to content

Fix copies=0 producing wrong VRS object type #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
korikuzma merged 3 commits into from
Apr 2, 2026
+13 −1
Merged

Fix copies=0 producing wrong VRS object type #621

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f603b53
fix copies=0 treated as falsy in CnvTranslator
knQzx Mar 26, 2026
55e2f47
add test for copies=0 in test_cnv_translator
knQzx Apr 2, 2026
397b7ef
Merge branch 'main' into fix/copies-zero-falsy
korikuzma Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ga4gh/vrs/extras/translator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,7 +573,7 @@ def _from_hgvs(
)

copies = kwargs.get("copies")
if copies:
if copies is not None:
cnv = models.CopyNumberCount(location=location, copies=copies)
else:
copy_change = kwargs.get("copy_change")
Expand Down