BUGFIX: resolve-route-and-navigate! drops params on cross-chart targets#31
Open
BUGFIX: resolve-route-and-navigate! drops params on cross-chart targets#31
Conversation
…ts (#30) When decode-url could not match a leaf to a local route element (cross-chart target), the fallback branch discarded URL query params. Fixed by returning params from the codec even without a leaf match, and passing them through in the fallback navigation path. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #30.
decode-urlin the transit codec now returns{:params ...}even when the leaf segment does not match a local route element (cross-chart targets). Previously the(when leaf-id ...)guard discarded parsed params entirely.resolve-route-and-navigate!now branches on:leaf-idinstead of the whole decoded map, and passes decoded params through in the fallback (deep-search) navigation path.URLCodecimplementations — codecs that still returnnilon no-match work identically because(:leaf-id nil)and(:params nil)are bothnil.Test plan
simulated_history_specpassurl_sync_headless_specunaffected (backwards compatible)🤖 Generated with Claude Code