fix(security): 2 improvements across 2 files#6194
Open
tomaioo wants to merge 2 commits into
Open
Conversation
- Security: Stored/Reflected XSS via unsanitized HTML in toast content - Security: Unsanitized HTML rendering in alert title Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
- Security: Stored/Reflected XSS via unsanitized HTML in toast content - Security: Unsanitized HTML rendering in alert title Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
ssiyad
requested changes
Apr 24, 2026
Member
ssiyad
left a comment
ssiyad
left a comment
There was a problem hiding this comment.
This may break existing HTML based content rendering. Can you please update this to use DOMPurify?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(security): 2 improvements across 2 files
Problem
Severity:
High| File:dashboard/src/components/CustomToast.vue:L22The component renders the
htmlprop usingv-htmlwithout sanitization. If this prop can contain user-controlled or server-returned content, attackers can inject arbitrary HTML/JavaScript, leading to account takeover or data exfiltration in the dashboard context.Solution
Avoid
v-htmlfor untrusted data. Render as plain text ({{ html }}) or sanitize strictly with a vetted sanitizer (e.g., DOMPurify) before rendering.Changes
dashboard/src/components/CustomToast.vue(modified)dashboard/src/components/AlertBanner.vue(modified)