feat(DynamicValueHandler): truncate middle of key instead of the end#592
Open
stravo1 wants to merge 6 commits into
Open
feat(DynamicValueHandler): truncate middle of key instead of the end#592stravo1 wants to merge 6 commits into
stravo1 wants to merge 6 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #592 +/- ##
========================================
Coverage 57.62% 57.62%
========================================
Files 29 29
Lines 3193 3193
========================================
Hits 1840 1840
Misses 1353 1353 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
using index as keys caused unexpected results on middle ellipsis upon search as the middle ellpsis status was being stored in the index
surajshetty3416
requested changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In deeply nested dynamic values, truncating end of the word gives very little context (if not none). Dynamic Value keys can be truncated at the middle to preserve context (similar to how file managers truncate filenames/paths), we also show full key on hover.
Before:

After:
