Handle ref pin patterns in borrowck#6
Merged
frank-king merged 1 commit intofrank-king:feature/pin-borrowckfrom May 3, 2026
Merged
Handle ref pin patterns in borrowck#6frank-king merged 1 commit intofrank-king:feature/pin-borrowckfrom
frank-king merged 1 commit intofrank-king:feature/pin-borrowckfrom
Conversation
Author
|
@frank-king This should address the remaining "ref pin" / borrowck coverage you requested in #5. Since rust-lang#153693 is still draft and the "Test pin pattern matching" task is still open there, would you prefer to merge this follow-up into "feature/pin-borrowck" before you do the final self-review / mark the upstream PR ready for review? No rush; just checking so I do not add noise in the upstream PR if you want this integrated first. |
a72c987
into
frank-king:feature/pin-borrowck
2 of 11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows up on the review comment from #5 asking for borrowck coverage for
ref pinpatterns.The new tests showed that
ref pin mut/ref pin constpatterns were not being treated equivalently to direct&pin mut/&pin constborrows. With only the new tests kept and the implementation files reverted, the new diagnostics were missing.This change makes pinned ref patterns lower to
BorrowKind::Pinned(..., PinBorrowKind::Persistent), while preserving the existing behavior for ordinary non-pinnedref/ref mutpatterns.Added coverage for:
ref pin mutfollowed by a later&mutref pin mutfollowed by a later moveref pin constfollowed by a later&mutref pin constfollowed by a later moveUnpinvs!Unpinbehavior