Skip to content

fix(tmux): deduplicate panes to prevent "duplicate session id" crash #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seflue wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

fix(tmux): deduplicate panes to prevent "duplicate session id" crash #297

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lua/sidekick/cli/session/tmux.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,11 @@ function M.panes(opts)
local cmd = opts.cmd or { "tmux", "list-panes", "-a", "-F", PANE_FORMAT }
local lines = Util.exec(cmd, { notify = opts.notify == true })
local panes = {} ---@type sidekick.tmux.Pane[]
local seen = {} ---@type table<string,boolean>
for _, line in ipairs(lines or {}) do
local session_id, id, pid, session_name, cwd = line:match("^(%$%d+):(%%%d+):(%d+):(.-):(.*)$")
if id and pid and session_name and cwd then
if id and pid and session_name and cwd and not seen[id] then
seen[id] = true
pid = assert(tonumber(pid), "invalid tmux pane_pid: " .. pid) --[[@as number]]
---@class sidekick.tmux.Pane
panes[#panes + 1] = {
Expand Down