fix(nes): accept callbacks without request ids#277
Open
alvarosevilla95 wants to merge 1 commit intofolke:mainfrom
Open
fix(nes): accept callbacks without request ids#277alvarosevilla95 wants to merge 1 commit intofolke:mainfrom
alvarosevilla95 wants to merge 1 commit intofolke:mainfrom
Conversation
alvarosevilla95
force-pushed
the
fix/nes-missing-request-id
branch
from
1864831 to
012c451
Compare
|
After hours trying to figure out why my nes stop working, I find your fix. Thank you, it also works for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed NES has stopped working for me recently, can't be sure how long tbh. Full disclosure I just had gpt-5.4 debug this for me
It seems the issue is that the neovim callbacks are not including the request_id any more, so all NES suggestions are getting dropped by the stale filter, so I added a check for nil to skip the filter logic. At least it's definitely fixed it on my end.