Add /go/onmaploaded design doc redirect#13200
Open
hearsilent wants to merge 1 commit intoflutter:mainfrom
Open
Add /go/onmaploaded design doc redirect#13200hearsilent wants to merge 1 commit intoflutter:mainfrom
hearsilent wants to merge 1 commit intoflutter:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a new redirect from /go/onmaploaded to a Google Docs design document. The change is straightforward, adding a new entry to the redirects array in firebase.json. The new entry is correctly placed to maintain the alphabetical order of the source paths, and its format is consistent with existing redirects in the file. I have reviewed the change and found no issues.
Member
|
/gcbrun |
Collaborator
|
Visit the preview URL for this PR (updated for commit 87ca5eb): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what this PR is changing or adding, and why:
Adds a
flutter.dev/goredirect for the public onMapLoaded Cross-Platform Semantics.This is needed so the design doc follows the Flutter design doc process and can be referenced from the tracking issue and review discussions.
Issues fixed by this PR (if any):
flutter/flutter#99610
PRs or commits this PR depends on (if any):
flutter/packages#10714
Presubmit checklist
of 80 characters or fewer.