Skip to content

[cupertino_icons] Remove empty Dart file#11308

Open
stuartmorgan-g wants to merge 1 commit intoflutter:mainfrom
stuartmorgan-g:cupertino-icons-remove-placeholder-source
Open

[cupertino_icons] Remove empty Dart file#11308
stuartmorgan-g wants to merge 1 commit intoflutter:mainfrom
stuartmorgan-g:cupertino-icons-remove-placeholder-source

Conversation

@stuartmorgan-g
Copy link
Collaborator

It used to be impossible to publish a package without a lib/ directory, which is why there is a placeholder file. That hasn't been true for quite a while, however, so we don't need to keep shipping an empty file.

This will also fix the questionable pana score deduction for not having any documentation (without us having to add a library directive just to document that no code is needed).

Part of flutter/flutter#183844

Pre-Review Checklist

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

It used to be impossible to publish a package without a lib/ directory,
which is why there is a placeholder file. That hasn't been true for
quite a while, however, so we don't need to keep shipping an empty file.

This will also fix the questionable pana score deduction for not having
any documentation (without us having to add a library directive just to
document that no code is needed).

Part of flutter/flutter#183844
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the empty lib/cupertino_icons.dart file, which was a placeholder that is no longer necessary. Correspondingly, the package version is updated to 1.0.9 in pubspec.yaml, and CHANGELOG.md is updated with an entry for this removal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD p: cupertino_icons triage-framework Should be looked at in framework triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant