[cupertino_icons] Remove empty Dart file#11308
Open
stuartmorgan-g wants to merge 1 commit intoflutter:mainfrom
Open
[cupertino_icons] Remove empty Dart file#11308stuartmorgan-g wants to merge 1 commit intoflutter:mainfrom
stuartmorgan-g wants to merge 1 commit intoflutter:mainfrom
Conversation
It used to be impossible to publish a package without a lib/ directory, which is why there is a placeholder file. That hasn't been true for quite a while, however, so we don't need to keep shipping an empty file. This will also fix the questionable pana score deduction for not having any documentation (without us having to add a library directive just to document that no code is needed). Part of flutter/flutter#183844
There was a problem hiding this comment.
Code Review
This pull request removes the empty lib/cupertino_icons.dart file, which was a placeholder that is no longer necessary. Correspondingly, the package version is updated to 1.0.9 in pubspec.yaml, and CHANGELOG.md is updated with an entry for this removal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It used to be impossible to publish a package without a lib/ directory, which is why there is a placeholder file. That hasn't been true for quite a while, however, so we don't need to keep shipping an empty file.
This will also fix the questionable pana score deduction for not having any documentation (without us having to add a library directive just to document that no code is needed).
Part of flutter/flutter#183844
Pre-Review Checklist
[shared_preferences]///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2